SEPURI-SAI-KRISHNA opened a new pull request, #44315:
URL: https://github.com/apache/superset/pull/44315

   ### SUMMARY
   
   `ControlPanelsContainer › renders ControlPanelSections` intermittently fails 
in `sharded-jest-tests (4)` with `Expected length: 5, Received length: 4` (3 
failures on 2026-09-14, one on `master`; details in #44314).
   
   The test clicks the Customize tab without awaiting it. That was harmless 
under `@testing-library/user-event` 12, where `click` was synchronous, but 
#43512 moved the repo to 14, where every call returns a promise and dispatches 
its events across timer yields. With the call un-awaited, the following 
`waitFor` starts while the click is still in flight, so the click's dispatch 
time comes out of `waitFor`'s 1000 ms budget. On a loaded runner that budget 
runs out before the Customize section renders.
   
   This PR adds the missing `await`. It is the only un-awaited `userEvent` call 
in the file. The assertion is unchanged: no widened timeout, no retries.
   
   Locally, instrumenting the test showed the click resolving +100 ms into 
`waitFor` (4 polls) without `await`, versus resolving before `waitFor` starts 
(1 poll) with it.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A: test-only change.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   cd superset-frontend
   npm run test -- src/explore/components/ControlPanelsContainer.test.tsx
   ```
   
   All 11 tests pass (5/5 local runs on Node 24.16.0).
   
   Note: I could not force the original failure locally. The unmodified test 
passed 12/12 runs under full CPU load, and shard 4 passed 3/3 runs pinned to 4 
cores with coverage. The case for the fix is the CI history in the linked issue 
plus the timing measurement above.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: Fixes #44314
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to