rusackas commented on PR #44256: URL: https://github.com/apache/superset/pull/44256#issuecomment-5684770839
Thanks for chasing this down, @sakshipatil-hue! The fix idea is right, but the diff doesn't actually parse - in `superset/dashboards/filters.py`, `no_viewer_query`'s outer paren (opened where the query starts, ~line 184) never gets closed once `or_(` wraps around `get_dataset_access_filters(...)` around line 223-231. That's a SyntaxError, which is why lint, unit tests, and every build/test job on this PR are red, not something unrelated to your change. Can you fix the paren nesting and push again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
