eschutho commented on PR #43468: URL: https://github.com/apache/superset/pull/43468#issuecomment-5687692071
@rusackas you're right, and thanks for the second set of eyes. Confirmed the same root cause independently (EngCodeReviewBot traced `extractQueryFields.ts`: in aggregate mode it discards `columns` and reads dimensions from `groupby` only, and `getStandardizedControls().popAllColumns()` — the one path that could recover a `columns` value — doesn't fire for these plain fixture files since they carry no `standardizedFormData` migration blob). ~13 of the 21 changed files (pie/echarts_timeseries_line/echarts_area/treemap_v2/sunburst_v2, aggregate-mode) would have lost their grouping dimension at render time. Worth stating plainly since it changes the fix here: the rename doesn't even accomplish its stated goal. The `DeprecationWarning` this PR set out to silence fires from `QueryObject.__init__` (`superset/common/query_object.py`) when a *query request* carries a `groupby` kwarg — that's populated per-request by the frontend's query-builder logic for these chart types, not by whatever key is stored in the example's persisted form data/YAML. Renaming the fixture's `groupby` → `columns` doesn't touch that path at all, so the production warning volume wouldn't have dropped either way. Given both, closing this without merging rather than pushing a revert commit — a revert brings every touched file back to exactly what's already on `master`, so there's nothing left to land. The real fix for the warning needs to happen further down the stack (query-object construction / frontend query-builder), not in these fixtures — flagging as a fresh follow-up rather than folding it into this PR's scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
