eschutho commented on PR #43725:
URL: https://github.com/apache/superset/pull/43725#issuecomment-5687983616
@aminghadersohi thanks for catching this — you're right that the old message
steered callers straight into creating a third duplicate row. Pushed
`87c13dd1e8`:
- Schema-scoped `MultipleResultsFound` message now reads: *"Multiple
datasets named '{table_name}' exist in schema '{schema}' of this database with
no catalog set. These are duplicate legacy rows; contact an admin to remove the
duplicates."* — dropped the "specify catalog" guidance entirely, per your
analysis of why it can't work on this path. Left the sibling no-schema branch's
message untouched, as you confirmed that one's accurate.
- Tightened the LOW test-assertion gap too:
`test_get_or_create_dataset_with_schema_returns_400_when_ambiguous` now asserts
the message's distinctive phrase instead of the bare substring `"catalog"`.
Didn't file a separate issue for the underlying duplicate-row cleanup (your
nit) — flagging it here instead so it's visible without expanding this PR's
scope. Ready for another look whenever you have a minute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
