bito-code-review[bot] commented on code in PR #44326:
URL: https://github.com/apache/superset/pull/44326#discussion_r4021785905
##########
pyproject.toml:
##########
@@ -202,7 +202,7 @@ fastmcp = [
# than that until Dependabot proposed mcp 2.1.1 and the resolver caught
# the conflict (#43876). Capped to match what fastmcp 3.x actually
# supports until this extra moves to fastmcp 4.x, which accepts mcp 2.x.
- "mcp>=1.29.1,<2.0",
+ "mcp>=2.2.0,<3.0",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Unsatisfiable dependency constraint</b></div>
<div id="fix">
This bump makes the `fastmcp` extra unsatisfiable: `fastmcp` stays at
`>=3.4.7,<4.0`, but the comment above (lines 201-204) documents that fastmcp
3.x requires `mcp<2.0`, and only fastmcp 4.x accepts mcp 2.x. The resolver will
fail to install this extra. Bump `fastmcp` to 4.x alongside this change, or
revert the `mcp` bump.
</div>
</div>
<small><i>Code Review Run #f10721</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
