rebenitez1802 commented on PR #43523: URL: https://github.com/apache/superset/pull/43523#issuecomment-5697268098
@sadpandajoe thanks for the thorough passes. Latest push (`c9e2da5325`) addresses all your open threads — replies inline on each. Summary: - **Timestamps:** reverted the UTC-aware change back to naive with a bounded negative-skew tolerance (per your "normalize or tolerate bounded skew" note) — keeps the serialized format backward-compatible for mixed-version pods and converges under clock skew, so no more naive−aware `TypeError` and no legacy-TZ offset staleness. - **Retained images:** `get_invalid_image_reason` now validates whenever an image is present (not just `UPDATED`); the chart on-demand retry marks the entry `COMPUTING` preserving the last-good image instead of wiping to `PENDING`. - **Docs:** opt-out text corrected (`0`/`None` disables the age check and falls back to the backend's own retention). - **Tests/fixtures:** naive fixtures; added retained-invalid-image and retry-preserves-image coverage. Would appreciate another review when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
