rusackas commented on PR #38762: URL: https://github.com/apache/superset/pull/38762#issuecomment-5700523053
Heya @Mayankaggarwal8055, this went quiet after my question in June about whether the global-scope expansion still works with the `isGlobalScope` branch gone from `getRelatedChartsForCrossFilter`. Tracing it through, I think it holds, since `crossFilters.ts` already resolves global scope before it gets here. Copilot's ask for a tabbed/global-scope test never landed though. Since it's been quiet, I'll add that test myself to lock it in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
