mikebridge commented on code in PR #44180:
URL: https://github.com/apache/superset/pull/44180#discussion_r4031486156
##########
superset/exceptions.py:
##########
@@ -206,7 +206,26 @@ class SpatialException(SupersetException):
class CertificateException(SupersetException):
- message = _("Invalid certificate")
+ def __init__(
+ self,
+ message: str = "",
+ exception: Optional[Exception] = None,
+ error_type: Optional[SupersetErrorType] = None,
+ ) -> None:
+ """Translate the default certificate error when constructing the
exception.
+
+ Deliberately diverges from the sibling pattern of a class-level
+ ``message`` default: translating at construction resolves to a
Review Comment:
Addressed in a2e72b45608e0e9f9dc09ab472f0b572868852a4: the
CertificateException docstring describes this subclass’s construction-time
translation without claiming a sibling class-level pattern. No behavior change.
The i18n suite passed (27 tests), pre-commit passed on all branch-changed
files, and an independent Claude review approved the final snapshot. The
retracted LazyString concern and accepted lint-rule follow-up remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
