mikebridge commented on PR #44255: URL: https://github.com/apache/superset/pull/44255#issuecomment-5707923309
Good catch on the frozen scroll offset in https://github.com/apache/superset/pull/44255#issuecomment-5687721350 — addressed in a4bb1f31aa1a9d79e0149854e0fc97d77de39665. The visible header bottom is remeasured on scroll/resize, bounded by header height, with feature/embed gating and exact listener cleanup. The closed-host collapse remains intact. Authenticated Chromium placement checks passed at 1920px and 1280px for both normal and /placement URL bases: 4 cases, no skips or retries, with real history API responses and asserted scrolling 0 → 240 → 0. Both component suites passed (59 tests), and scoped pre-commit including frontend type checking passed. Independent final-tree review found no blockers; a cosmetic z-index comment nit remains. The development build retains its MapLibre warning, and the isolated backend still exhibits the separate activity-logging cursor issue tracked by #44261; those are not claimed fixed here. This also merges repaired master 4c77b0b924a9bd770110915eacd68f5619e8241d (#44364), resolving the conflict without a new migration. Fresh published-head CI is pending; no all-green claim yet. Posted by Codex (AI) on behalf of @mikebridge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
