codeant-ai-for-open-source[bot] commented on code in PR #44184:
URL: https://github.com/apache/superset/pull/44184#discussion_r4032794712
##########
superset/commands/dashboard/create.py:
##########
@@ -44,6 +49,17 @@ def __init__(self, data: dict[str, Any]) -> None:
def run(self) -> Model:
self.validate()
dashboard = DashboardDAO.create(attributes=self._properties)
+ # Surface the INSERT here rather than at the transaction decorator's
+ # commit, so a slug collision with a SOFT-DELETED dashboard (possible
+ # only on the full-constraint dialects; the partial-index dialects
+ # free the slot) can be translated into restore guidance. Any other
+ # integrity failure re-raises unchanged.
+ try:
+ db.session.flush()
+ except IntegrityError as ex:
+ db.session.rollback() # pylint: disable=consider-using-transaction
+
raise_for_soft_deleted_slug_collision(self._properties.get("slug"), ex)
Review Comment:
**Suggestion:** When this command runs inside an existing
`g.in_transaction`, `rollback()` aborts unrelated pending changes owned by the
outer operation.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ
`Transaction/lifecycle`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0c7aad559541472bb31456dc58fd67d3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0c7aad559541472bb31456dc58fd67d3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/dashboard/create.py
**Line:** 59:61
**Comment:**
*Transaction Lifecycle: When this command runs inside an existing
`g.in_transaction`, `rollback()` aborts unrelated pending changes owned by the
outer operation.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44184&comment_hash=ba74c75a3b1da10e269f2ac0f8c036dbb97e630ecf2e47f48e03cd301ef2c0a3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44184&comment_hash=ba74c75a3b1da10e269f2ac0f8c036dbb97e630ecf2e47f48e03cd301ef2c0a3&reaction=dislike'>๐</a>
##########
superset/commands/dashboard/update.py:
##########
@@ -112,6 +116,15 @@ def run(self) -> Model:
self._model,
{k: v for k, v in self._properties.items() if k !=
"json_metadata"},
)
+ # See CreateDashboardCommand.run: translate a slug collision
+ # with a soft-deleted dashboard (full-constraint dialects) into
+ # restore guidance; anything else re-raises unchanged.
+ try:
+ db.session.flush()
+ except IntegrityError as ex:
+ db.session.rollback() # pylint:
disable=consider-using-transaction
+
raise_for_soft_deleted_slug_collision(self._properties.get("slug"), ex)
Review Comment:
**Suggestion:** When this command runs inside an existing
`g.in_transaction`, `rollback()` discards unrelated staged dashboard, tag, and
relationship changes from the outer operation.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ
`Transaction/lifecycle`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a1aa1a0d7c7a4c2583c7bb07fc7c8658&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a1aa1a0d7c7a4c2583c7bb07fc7c8658&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/dashboard/update.py
**Line:** 124:126
**Comment:**
*Transaction Lifecycle: When this command runs inside an existing
`g.in_transaction`, `rollback()` discards unrelated staged dashboard, tag, and
relationship changes from the outer operation.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44184&comment_hash=261635feb821b06120c94b889c5860bd1d7e4e9ba8f077313f73f9f329bc4ea7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44184&comment_hash=261635feb821b06120c94b889c5860bd1d7e4e9ba8f077313f73f9f329bc4ea7&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
