sadpandajoe commented on code in PR #42760:
URL: https://github.com/apache/superset/pull/42760#discussion_r4032855081
##########
superset/charts/data/api.py:
##########
@@ -575,6 +575,9 @@ def _process_data(query_data: Any) -> Any:
)
resp = make_response(response_data, 200)
resp.headers["Content-Type"] = "application/json; charset=utf-8"
+ resp.headers["X-Superset-Semantic-Cache"] =
SemanticCacheStatus.combine(
Review Comment:
For `result_type=results`, query-actions reduces each payload to its results
whitelist and drops `semantic_cache_status`; this new header therefore combines
only `None` values and reports `MISS` even when containment served the query.
Could the results payload retain the status before computing the header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]