mikebridge commented on PR #44261: URL: https://github.com/apache/superset/pull/44261#issuecomment-5708772162
Prepared by Codex at Mike's request. Following up on Bito's cursor-name timing note (https://github.com/apache/superset/pull/44261#issuecomment-5707265623): could we retain the named-cursor assertion? SQLAlchemy 2.0.52's `_PGExecutionContext_common_psycopg.create_server_side_cursor` constructs the identifier and calls `self._dbapi_connection.cursor(ident)` before execution; it is not first assigned inside `do_execute`. I inspected that installed implementation and exercised its cursor-creation call. The actual PostgreSQL CI job at tested merge `268ec0434d3ab355587ea03d4679019fe38534c0` logs `tests/integration_tests/versioning/activity_write_after_read_tests.py .` (not skipped), then `2791 passed, 165 skipped`: https://github.com/apache/superset/actions/runs/35166198716/job/105027834221 . Published head remains `bfd6f58fc7d2d2631a2b8809ba4881a2a6cd0e06`. The earlier negative controls and fix are linked in https://github.com/apache/superset/pull/44261#discussion_r4031515073 . An execution-options-only assertion would weaken the regression the reviewer requested. This disposes the timing objection as a false positive; it does not claim reviewer approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
