mikebridge commented on PR #44267: URL: https://github.com/apache/superset/pull/44267#issuecomment-5717969863
Good catch on the saved-chart fallback using an edited semantic datasource. Published eca7c185e9d0e96837bfb5f48d66f5f43f968343 resolves the cached datasource before SQL construction and returns Unsupported for semantic_view. Coverage includes both cached encodings, ordinary table passthrough, and guest denial; removing the guard made the two semantic cases fail. The affected suite passes all 87 tests, and scoped mandatory pre-commit including MyPy passed on the published tree. Fresh CI is still running, so these local results are not a claim that the new CI head is green. Could you take another look at the fallback when convenient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
