rusackas commented on PR #37396: URL: https://github.com/apache/superset/pull/37396#issuecomment-5719682234
Fair points on both counts. The verbose_map drilling on master is hacky, I won't defend it, it's just what landed first, and open to revision/refinement. That's an argument for consolidating on collabels rather than living with two paths. On the contribution suffix, agreed a boolean field (e.g. is_contribution) belongs on the column metadata rather than getting inferred from the label string, that's the cleaner shape. If you want to bring that over as part of extract_display_labels here, I'm fine with that direction, just needs a test alongside it this time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
