rusackas commented on PR #42412: URL: https://github.com/apache/superset/pull/42412#issuecomment-5719745369
Couple of things before this can merge. It's got conflicts with `master` now, so it'll need a rebase, and CI hasn't actually run yet, just the docs/label checks, so there's no test signal until that's sorted. Also, @amaannawab923's thread on the psycopg2 buffering is still open, worth answering before this goes in. A plain cursor() from get_raw_connection() buffers the whole result set client-side on postgres, which undercuts the point of a streaming export. Might be worth a server-side cursor there, or at least calling out the tradeoff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
