mikebridge commented on PR #43827: URL: https://github.com/apache/superset/pull/43827#issuecomment-5722393788
Two follow-ups are pushed: - `75b9ca951b` adds coverage for malformed references and the bounded schema walker. The semantic-layer suite passes **523 tests with 100% line/branch coverage**, correcting the CI coverage-gate failure. - `ca6837ca11` prevents restored credentials from appearing in chained Pydantic validation exceptions logged by create/update. Both commands use one helper that returns only field paths/error codes, omits input/messages/context, and suppresses the original cause. It also rejects unsupported `$ref` forms instead of aliasing their final path segment. Final local verification: **595 tests passed**, including real POST/PUT caplog regressions for discriminator and custom-validator failures; semantic-layer coverage remains **100%**. Changed-file pre-commit (including MyPy) and explicit Pylint checks passed. Independent security review approved the fix, with its small shared-helper/error-detail follow-ups applied. The unconstrained-schema policy discussed above is unchanged. CI for the new head is pending; non-Pydantic provider exceptions that interpolate credentials remain a separately recorded follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
