deepujain commented on code in PR #43806:
URL: https://github.com/apache/superset/pull/43806#discussion_r4043709469
##########
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx:
##########
@@ -233,6 +233,29 @@ const defaultResizableConfig = (hideFooter: boolean |
undefined) => ({
},
});
+/** Merge caller overrides without dropping default resize-handle guards. */
+export function mergeResizableConfig(
+ hideFooter: boolean | undefined,
+ overrides: ModalProps['resizableConfig'] = {},
+): NonNullable<ModalProps['resizableConfig']> {
+ const defaults = defaultResizableConfig(hideFooter);
+ if (!overrides || Object.keys(overrides).length === 0) {
+ return defaults;
+ }
+ const { enable: enableOverride, ...restOverrides } = overrides;
+ return {
+ ...defaults,
+ ...restOverrides,
+ enable:
+ enableOverride === false
+ ? false
+ : {
+ ...defaults.enable,
+ ...(typeof enableOverride === 'object' ? enableOverride : {}),
+ },
Review Comment:
Thanks for checking this. Superset pins re-resizable 6.11.2, whose published
ResizableProps type defines enable as Enable | false; true is not a valid
value. The merge therefore intentionally handles false and object overrides,
while undefined retains the defaults. No true branch is needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
