codeant-ai-for-open-source[bot] commented on code in PR #43887:
URL: https://github.com/apache/superset/pull/43887#discussion_r4043743754
##########
superset/semantic_layers/api.py:
##########
@@ -1083,10 +1087,12 @@ def _fetch_connection_items(
source_type: str,
name_filter: str | None,
) -> list[tuple[str, Any]]:
- """Fetch database and semantic layer items based on filters."""
+ """Fetch permitted sources using the same FAB identity as the route
gate."""
db_items: list[tuple[str, Database]] = []
- if source_type in ("all", "database"):
- db_q = db.session.query(Database).options(
+ if source_type in ("all", "database") and security_manager.has_access(
+ "can_read", "Database"
+ ):
Review Comment:
**Suggestion:** A public `can_read` grant passes `protect_read`, but this
branch uses `has_access` instead of the anonymous-aware `can_access`, so public
database sources can disappear from the response.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7e81431fdf304574b2d3a2650cdff11f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7e81431fdf304574b2d3a2650cdff11f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/api.py
**Line:** 1092:1094
**Comment:**
*Security: A public `can_read` grant passes `protect_read`, but this
branch uses `has_access` instead of the anonymous-aware `can_access`, so public
database sources can disappear from the response.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43887&comment_hash=f6bda4ae8bb4f0e6779f790d8238800c4fa53ba166747f2d4eaaba6daa8d0c3f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43887&comment_hash=f6bda4ae8bb4f0e6779f790d8238800c4fa53ba166747f2d4eaaba6daa8d0c3f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
