bito-code-review[bot] commented on code in PR #43004:
URL: https://github.com/apache/superset/pull/43004#discussion_r4047836051
##########
superset-frontend/playwright.config.ts:
##########
@@ -119,6 +124,8 @@ export default defineConfig({
// via API with unique names — no shared mutable state between tests.
name: 'chromium-sqllab',
testMatch: '**/tests/sqllab/**/*.spec.ts',
+ // See the chromium-gaq project below.
+ testIgnore: '**/global-async-query*.spec.ts',
Review Comment:
<!-- Bito Reply -->
The explanation regarding the necessity of the exclusion pattern is clear.
Since the test suite requires the global async queries flag provided by the
specific workflow step, excluding it from the standard SQL Lab run prevents it
from being collected and skipped repeatedly, which would otherwise lead to
inaccurate coverage reporting. The current configuration correctly maintains
the intended test isolation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
