eschutho commented on PR #44429: URL: https://github.com/apache/superset/pull/44429#issuecomment-5732132704
@rebenitez1802 — routing this to you. It's the same `superset/models/helpers.py` bug-cleanup lane you've been carrying end-to-end (most recently #44172), and the fix is a SQLAlchemy-compiler dialect quirk — squarely your #43864 territory: `.like(escape=…)` renders a literal `ESCAPE` clause via the base compiler, which `sqlalchemy-bigquery`'s `BigQueryCompiler` doesn't override, so it leaks into GoogleSQL; the PR switches to `.contains(autoescape=True)`, which the dialect *does* override. Pipeline-authored (eschutho, Sentry burndown SUPERSET-PYTHON-176K / SC-121408), self-reviewed, CI green-bar, small diff (+34/-45, two files, new regression test). Two things worth confirming in your read: (1) that `build_like_predicate` is actually the predicate path `DatasourceRestApi.get_column_values` dispatches — the Sentry culprit — and (2) that the `.contains(autoescape=True)` swap stays a genuine no-op on postgres/mysql/sqlite. Your tracker load is the highest on the roster right now — happy to re-route if you're underwater. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
