deepujain commented on code in PR #44271:
URL: https://github.com/apache/superset/pull/44271#discussion_r4051355250
##########
superset-frontend/packages/superset-ui-core/src/query/getClientErrorObject.ts:
##########
@@ -297,12 +303,31 @@ export async function getErrorText(
error,
);
}
- if (typeof message === 'string' && message === 'Forbidden') {
+ if (status === 403) {
Review Comment:
Fixed in ae9448392e. getErrorText now uses the generic permission copy only
when the normalized error equals the canonical 403 fallback, so specific
backend messages remain visible. Added a regression covering a JSON 403 with
specific chart-creation text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
