bito-code-review[bot] commented on code in PR #44457:
URL: https://github.com/apache/superset/pull/44457#discussion_r4055929969
##########
superset-frontend/scripts/po2json.sh:
##########
@@ -30,8 +30,8 @@ do
filename="${file%.*}"
if [ $extension == "po" ]
then
- echo "po2json --domain superset --format jed1.x $file $filename.json"
- po2json --domain superset --format jed1.x --fuzzy $file $filename.json
+ echo "po2json --domain superset --format jedold $file $filename.json"
+ po2json --domain superset --format jedold --fuzzy $file $filename.json
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>wrong po2json format breaks i18n</b></div>
<div id="fix">
`--format jedold` targets Jed < 1.1.0, but the frontend runtime uses Jed
^1.1.1 (`packages/superset-core/package.json`). The fork's `lib/parse.js` only
`.shift()`s the leading msgid_plural/null element for `jed`; `jedold` keeps it,
so Jed 1.1.1's `dcnpgettext` reads `val_list[0]` as null and falls back to the
English msgid, breaking translations. Use `--format jed`.
</div>
</div>
<small><i>Code Review Run #255c9d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
