aminghadersohi commented on code in PR #44370:
URL: https://github.com/apache/superset/pull/44370#discussion_r4056566883
##########
superset-frontend/src/components/Chart/ChartRenderer.test.tsx:
##########
@@ -483,3 +500,32 @@ test('does not render chart during loading when last data
has errors', () => {
const { queryByTestId } = render(<ChartRenderer {...props} />);
expect(queryByTestId('mock-super-chart')).not.toBeInTheDocument();
});
+
+test('chart mask updates preserve incoming selection provenance', () => {
+ const updateDataMask = jest.fn();
+ render(
+ <ChartRenderer
+ {...requiredProps}
+ latestQueryFormData={{
+ datasource: '7__semantic_view',
+ viz_type: 'table',
+ semantic_selection_version: 'cube-member-id-v1',
Review Comment:
Verified at fa66bca4 by execution: baseline is 18/18 green, and deleting
`...(sourceForm.semantic_selection_sources ?? [])` now reds this test (1 failed
/ 17 passed). All six clause-level mutants in that array — including clause
order and the version field — are killed. Closing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
