rusackas commented on PR #43333: URL: https://github.com/apache/superset/pull/43333#issuecomment-5755976152
One thing before I approve, though. Bito's flag on the resize anchoring looks right to me: `bounds` only gets populated in `onDragStart`, so the `setPosition` calls inside `onResize` (Modal.tsx around line 419) never go through any clamping. A big enough resize from the top or left edge could push the modal off-screen, and if `draggable` is false there's no drag left to pull it back. Mind adding a bounds check there, @Lothnic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
