I3eka commented on PR #44498: URL: https://github.com/apache/superset/pull/44498#issuecomment-5760689073
@sadpandajoe, the shared base compatibility work is now separated and incorporated in this draft. Head `1f3d218e9b` includes master `fc016454fb` and [maintenance commit f1bb680209](https://github.com/I3eka/superset/commit/f1bb68020966deef58b7b9248796303df866d779). That addresses the reproduced missing AI imports and multiple migration heads, and fixes the Redis constructor/probe imports that mocked tests had concealed. The empty-chat change is still exactly the original three-file patch; [this comparison](https://github.com/I3eka/superset/compare/f1bb68020966deef58b7b9248796303df866d779...1f3d218e9b267880b65c072fc787ec8e6eb775db) excludes the shared maintenance. No other focused AI fixes were folded into it. Fresh checks on this head: 696 backend tests, 146 frontend tests, and all applicable pre-commit checks over 113 PR files pass. The common base also passes 7 real-Redis worker/probe cases with isolated SQLite and EchoProvider. The earlier Escape/type limitations no longer occur on this merged tree. Migration proof is the connected graph, not a full upgrade/downgrade cycle; worker proof is a thread plus real Redis, not Celery broker/crash recovery. The previous CI failures remain documented above, and I will check the new runs rather than infer CI success from local tests. The #42805/SIP prerequisite still applies, and the #43136 empty-chat thread stays open until that branch actually inherits the fix. No deployment or hold-label change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
