aminghadersohi commented on PR #44435: URL: https://github.com/apache/superset/pull/44435#issuecomment-5767047723
@gabotorresruiz thanks for running it rather than reading it — the `columns[1]` divergence is a real find. Agreed on the follow-up: `apply_dashboard_filter_context` writing `columns[0]["timeGrain"]` unconditionally is wrong wherever the axis is not at index 0, and it also leaves an inert `timeGrain` on a non-axis column. Tracked separately so it gets a regression test with the axis at a non-zero index, which is the only shape where the two rules differ. Nothing changing on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
