kokhlo commented on issue #44436: URL: https://github.com/apache/superset/issues/44436#issuecomment-5767868882
Follow-up on my claim above: this is fixed on master as of #44445 (`43fee87672`, merged 2026-09-19), which added a sibling `_restore_context` helper in the same file but never linked this issue. My PR #44437 carried the same diagnosis and was closed as superseded — gabotorresruiz verified there that the six tests fail with `sqlite3.ProgrammingError: Error binding parameter 1: type 'MagicMock' is not supported` at this issue's `128c0c1` and give 17 passed at master `322eaeaf99`, and that the mutation check on `_do_restore` (dropping `with_for_update()`, `populate_existing()`, the uuid pin or `deleted_at=None`) still turns `test_restore_version_concurrency.py` red. Nothing left to ship here — this issue can be closed as fixed by #44445. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
