rusackas commented on PR #43303: URL: https://github.com/apache/superset/pull/43303#issuecomment-5768707431
Heya @eugeneo17, appreciate you sticking with this one. The three threads you left open all seem like the right direction to me: fail closed when an adhoc filter can't be mapped, re-inject the imported chart's own `slice_id` once `import_from_dict` hands it an id, and the backfill CLI test as a follow-up. I'd go ahead with the first two, though @sadpandajoe raised both so he should probably confirm. Also, the pending checks aren't you... CI on this one needs a manual approval since the diff touches a workflow file, I just triggered it to run, but holler if it needs attention again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
