rusackas commented on PR #43762: URL: https://github.com/apache/superset/pull/43762#issuecomment-5768936511
Heya @ShauryaaIBM, big PR, appreciate the detail in the description. CI's not green yet though, and one looks like a real bug rather than just lint noise: `TabsRenderer.tsx` references `css` without importing it, which is probably what's cascading into the jest/playwright failures too. Pre-commit's also catching some mypy gaps in `test_browser_print_pdf.py` and a literal color in `printMode.ts` that should be a theme token. Once those are sorted and CI's green, happy to take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
