rusackas commented on PR #43192: URL: https://github.com/apache/superset/pull/43192#issuecomment-5769080012
Rebased onto current `master` on Bikash's behalf, no code changes otherwise. One real conflict in `eventHandlers.ts`/`eventHandlers.test.ts`: #42559 landed independently on `master` on 2026-08-28 and already added an equivalent guard for the missing-labelMap case, so that part of this fix is now redundant with master. This PR's second half — treating an empty `groupbyValues` as "no filters" in the filter-building ternary — is still missing from master and is the part that survives the rebase. Kept both sides' non-duplicate test coverage (the empty-name click, the context-menu case, and the combined "Total"/"Other" click are all new; dropped the one test that fully duplicated an already-existing, unrelated-to-this-conflict test for plain deselection). Ready to merge once CI's green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
