rusackas commented on PR #44099: URL: https://github.com/apache/superset/pull/44099#issuecomment-5769650743
This is careful work on the race-condition side (the stale-response guards are a nice catch beyond what the issue even asked for), but I don't think it closes #42679 all the way. `TimeRange.tsx` in `components/ListView/Filters` is a near-identical picker used for the Charts/Datasets list filters, and it does its own raw API call with no since/until equality check at all, so the same silent-empty-range bug is still reproducible there. `fetchTimeRange.ts`'s time-comparison/shift branch is missing the `isEmpty` flag too, so a period-over-period comparison that collapses to an empty range gets no signal either, even in the file this PR patches. Worth extending to both before marking this ready for review. Holler if you'd like a hand tracking down the other call sites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
