rusackas commented on PR #44276: URL: https://github.com/apache/superset/pull/44276#issuecomment-5769753856
Heya @justinpark, nice progress since sadpandajoe's pass. The CSS null-coalescing fix and the filterState-only update look like they cover those two threads, and the dashboard/explore gating landed too. Still a few threads open that read like real correctness gaps, not nits: the pre-normalization `form_data` mismatch on `getQuery`/`getChartData`, the missing `ownState` on paginated results, and the `GLOBAL_ASYNC_QUERIES` 202 envelope case. Also curious about the `getLayout()` type export, since the doc example doesn't actually compile as written. Solid foundational work on the extensions API though. Let's get those sorted before this one's merged, if we can. Holler if you want a hand with an of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
