rusackas commented on PR #44307: URL: https://github.com/apache/superset/pull/44307#issuecomment-5769771523
Heya @kokhlo, nice catch narrowing this down, the approach fits how #42582 handles the UUID case. One thing before this is mergeable though: EnxDev's finding above looks right, `slug=""` skips the guard but `import_dashboard()` treats it as a real identity value with `is not None`, so an empty-slug dashboard could still absorb the incoming charts silently. Swapping to `slug is None` plus a regression case for it should close the gap. Also this has drifted from `master`, CI's red across the board and the sqlite run is hitting multiple alembic heads, so a rebase should clear most of that up. I'll see if I can tackle that now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
