rusackas commented on PR #42849: URL: https://github.com/apache/superset/pull/42849#issuecomment-5769552953
Title and lint are sorted now, thanks. The `unit-tests`/`unit-tests-required` reds look like the artifact-upload step hitting a 403 from GitHub, not anything in the diff (all 16k+ tests actually passed), so nothing to fix on your end there. As noted above though, `dashboardTimeGrainAllowlist` is still pulled via `useContext(ReactReduxContext)` + `store.getState()` instead of `useSelector`, and I'm still not sure why this needs its own `time_grain_allowlist` field instead of extending the per-filter `timeGrains` allowlist that already exists. Would still like to see those addressed before this moves further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
