rusackas commented on PR #43960: URL: https://github.com/apache/superset/pull/43960#issuecomment-5769914549
Following up on the two open CodeAnt threads since my approval only spoke to one of them. The `TS_REGEX` export claim is still wrong, `export const TS_REGEX` is right there and `denormalizeTimestamp` imports it fine, nothing to do. The compact-offset one (`+0330` passed to `new Date`) was actually a fair catch that I missed in the approval, sorry for the confusion there. `new Date(...)` only reliably parses an offset with a colon per the ECMA-262 Date Time String Format, a colon-less offset is outside that grammar and browsers are known to disagree on how to parse it. Pushed `b1c5c81` to insert the colon on the way out, doesn't change the instant, just its spelling, and updated the one test that asserted the colon-less form passed through untouched. @sadpandajoe your Trino thread is also handled, confirmed the space-before-offset case in the current code and it matches what you flagged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
