rusackas commented on PR #44459: URL: https://github.com/apache/superset/pull/44459#issuecomment-5770005874
Thanks for tackling this, @hainenber! The reviewer's note on the function wrapper made this a lot easier to follow. Couple of things to look into before I approve, though. Bito's flagging that `parseArgs` defaults to `strict: true` in `scripts/build.js`, so an unrecognized flag or extra positional arg would now crash the build, where the old `yargs` parser just tolerated it; `strict: false` would probably restore that. It also caught a dead ternary branch in `defaultEntryFilename`, though that one looks preexisting, not something this PR introduced. CI's green across the board otherwise. Mind taking a pass at those two threads before we merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
