bito-code-review[bot] commented on code in PR #44504:
URL: https://github.com/apache/superset/pull/44504#discussion_r4070045538
##########
superset/security/password_change.py:
##########
@@ -36,14 +36,15 @@
from sqlalchemy.exc import IntegrityError
from superset.utils.decorators import transaction
+from superset.views.health import health_blueprint
Review Comment:
<!-- Bito Reply -->
The suggestion to move the import of `health_blueprint` inside
`register_password_change_enforcement` is appropriate. It effectively resolves
the identified circular dependency by deferring the import until the function
is actually called, preventing the premature initialization of the Superset
application during module-level execution.
**superset/security/password_change.py**
```
def register_password_change_enforcement():
from superset.views.health import health_blueprint
# ... rest of the function
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
