aipiJuancho opened a new pull request, #44531: URL: https://github.com/apache/superset/pull/44531
### SUMMARY Fixes #44530 The vertical filter bar receives `clearAllTriggers`/`onClearAllComplete` from `FilterBar` but never forwards them to `<FilterControls>`, so the `clearAllTrigger` hook never reaches filter plugins. As a result, after "Clear all" a Select filter's local `useImmerReducer` state stays frozen at the last selection, and re-selecting the same value is discarded by the reducer's `JSON.stringify` equality guards (silent no-op; the "Apply filters" button stays disabled). `Horizontal.tsx` already forwards both props; this restores parity for the vertical bar and adds them to the `filterControls` `useMemo` deps so the memoized element is rebuilt when a clear-all trigger fires. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A (behavioral fix; repro steps and root-cause analysis in the linked issue) ### TESTING INSTRUCTIONS **Manual:** vertical filter bar + a Select filter → select a value → Apply → Clear all → re-select the same value → the tag appears and "Apply filters" enables. **Automated:** suggested addition to `FilterBar.test.tsx` — render the vertical bar, select a value, apply, click "Clear all", re-select the same value and assert the dataMask receives the new selection. Happy to add it to this PR if maintainers want it included. ### ADDITIONAL INFORMATION - [x] Has associated issue: #44530 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
