flcrom commented on issue #44532: URL: https://github.com/apache/superset/issues/44532#issuecomment-5778463797
Taking this one. Both off-by-ones check out on master: the `- 1` in `getMonthWeekNumber` sends the first cell to column -1 when the 1st lands on the week start, and the week-subdomain `defaultColumnNumber` for month domains returns one column short of what `computeWeekSubDomainSize` generates. Will fold in the `indexOf` guard for the year-domain crash as well. PR coming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
