aminghadersohi opened a new pull request, #44534:
URL: https://github.com/apache/superset/pull/44534

   TL;DR: Align the two frontend workflow cache consumers with the Dockerfile's 
existing `3.11-slim-trixie` default to fix the cache-reference guard test on 
master.
   
   ### SUMMARY
   Master is currently red on 
`tests/unit_tests/scripts/docker_cache_ref_test.py::test_cache_ref_matches_dockerfile_py_ver`:
 running the test file on unchanged master reproduces two failures and three 
passes.
   
   #44250 added the guard test and changed both frontend workflow cache 
references to `apache/superset-cache:3.11.14-slim-trixie` without changing 
`Dockerfile`'s `ARG PY_VER=3.11-slim-trixie`. The test has no skip logic for 
this mismatch.
   
   Align the consumers back to `apache/superset-cache:3.11-slim-trixie`, which 
also matches the cache exporter derived from the Dockerfile. All five files in 
`CACHE_REF_CONSUMERS` were checked; the three Compose files already match and 
need no changes.
   
   The Dockerfile is intentionally unchanged. Pinning its Python base image to 
`3.11.14` would change the base-image selection for Python images, a separate 
product decision outside this CI fix.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Not applicable; CI configuration only.
   
   ### TESTING INSTRUCTIONS
   Run:
   ```sh
   PYTHONPATH=superset-core/src pytest 
tests/unit_tests/scripts/docker_cache_ref_test.py -q
   uvx pre-commit run --files .github/workflows/superset-frontend.yml 
.github/workflows/frontend-bundle-size-nightly.yml
   ```
   
   Local results: all five tests pass, and all applicable pre-commit hooks 
pass. Before the change, the same test command fails for the two workflow 
consumers.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to