bito-code-review[bot] commented on code in PR #43088:
URL: https://github.com/apache/superset/pull/43088#discussion_r4074830640
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts:
##########
@@ -558,7 +570,7 @@ export default function transformProps(
backgroundColor: theme.colorBgContainer,
},
},
- data: transformedData,
+ data: transformedData as any,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>any type cast</b></div>
<div id="fix">
`as any` discards type safety on the pie series payload and violates the
repo's org-mandated 'NO `any` types' rule (CLAUDE.md:38, dev-standard.mdc:16,
AGENTS.md:38). `PieChartDataItem` adds `isOther` beyond the echarts data item;
type it explicitly (e.g. intersect `PieSeriesOption['data'][number]` with `{
isOther?: boolean }`) rather than casting to `any`.
</div>
</div>
<small><i>Code Review Run #e9939e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
