rebenitez1802 commented on PR #43523: URL: https://github.com/apache/superset/pull/43523#issuecomment-5782795107
Heads-up for re-review — this is now rebased onto master's screenshot-cache refactor (the `should_enqueue_task` / coalescing / API-generation-pointer rewrite), so the diff has shifted since the last pass: - Feature threads `check_updated_staleness` through `should_enqueue_task` → `should_trigger_task` (single injection at the dashboard's `should_enqueue()` helper); `retry_fresh_error` and the coalescing window are preserved. - The guarded `_age_seconds()` is applied to master's `is_in_progress_stale(max_age_seconds)` so both the coalescing param and the tz/skew robustness hold. - The chart endpoint picked up two review-flagged fixes (independent of the feature): no pre-write before enqueue (a force-less request otherwise churned COMPUTING and never rendered), and the serving GET now returns any retained valid image instead of gating on `status == UPDATED`. - Kept both master's new coalescing unit tests and the updated-staleness tests. CI is green and I've updated the description's design-decision section to match. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
