sadpandajoe commented on code in PR #43471: URL: https://github.com/apache/superset/pull/43471#discussion_r4076697333
########## UPDATING.md: ########## @@ -74,10 +74,12 @@ tags are included in asset export and import. **What operators should expect:** -- **Implicit tags accrue.** Saving a chart, dashboard, dataset or saved query, - and favoriting an asset, write rows to `tag` and `tagged_object` (`type:chart`, - `editor:<user id>`, `favorited_by:<user id>`). These have always been created - when the flag was on; they are simply no longer opt-in. +- **Implicit tags no longer accrue.** Saving a chart, dashboard, dataset or + saved query, and favoriting an asset, used to write rows to `tag` and + `tagged_object` (`type:chart`, `editor:<user id>`, `favorited_by:<user id>`). + That generation has since been removed; see "Superset no longer Review Comment: This still says the tag-creation listeners are attached and honor `TAGGING_SYSTEM` at write time, but this change removes those listeners entirely. That leaves the upgrade guide describing behavior that no longer exists; could this bullet be updated or removed while preserving the unconditional cleanup detail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
