sadpandajoe commented on code in PR #44103: URL: https://github.com/apache/superset/pull/44103#discussion_r4076817679
########## .github/workflows/chromatic.yml: ########## @@ -0,0 +1,133 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Publishes superset-frontend's Storybook to Chromatic for visual +# regression testing. See https://www.chromatic.com/docs/github-actions +# +# Runs on pushes to master (keeps the Chromatic baseline in sync with +# mainline) and on pull requests that touch superset-frontend. Fork PRs +# don't receive CHROMATIC_PROJECT_TOKEN -- GitHub withholds repository +# secrets from pull_request runs triggered by a fork -- so the publish +# steps below no-op for them (via the CHROMATIC_PROJECT_TOKEN != '' guard) +# rather than failing. +# +# Non-blocking for now (exitZeroOnChanges: true): visual changes are +# surfaced as a PR check/comment for review, not enforced as a merge gate. +# A prior Chromatic setup here (#21095) was removed in #27232 for being +# unmaintained and overlapping with Applitools (since also discontinued). +# Keep this one simple and watch it before considering a required check. +# +# The master (push) run auto-accepts its own changes so the baseline stays +# current; otherwise every subsequent PR would keep reporting the same +# already-merged diff against a stale baseline. PR runs are left alone so a +# human still reviews what changed. +name: Chromatic + +on: + push: + branches: + - master + paths: + - "superset-frontend/**" + pull_request: Review Comment: Because this PR only changes this workflow, neither path filter matches its merge commit, so no master build establishes the accepted baseline; a manual dispatch also leaves `autoAcceptChanges` false. Could we include this workflow in the filters or make a master dispatch accept the bootstrap build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
