bito-code-review[bot] commented on PR #43900: URL: https://github.com/apache/superset/pull/43900#issuecomment-5784921230
<!-- Bito Reply --> The documentation accurately reflects the current implementation described in the diff. The `manage_dashboard_roles` tool stores the roles list regardless of the `ENABLE_VIEWERS` flag, but the dashboard access check logic (which is external to this tool) relies on the flag to determine whether to enforce those restrictions. If the flag is disabled, the stored roles are indeed inert, but the dashboard access check logic may still be evaluating the presence of roles if it is not also gated by the same flag. It is recommended to ensure that the dashboard access check logic is consistently gated by `ENABLE_VIEWERS` to prevent unintended access restrictions when the flag is disabled. **docs/developer_docs/extensions/mcp.md** ``` +- **`ENABLE_VIEWERS` gating**: dashboard access roles only take effect when + the `ENABLE_VIEWERS` feature flag is enabled. The response always reports + the flag's current state via `viewers_enabled`, and `warnings` notes when + a change was applied but has no live effect (the roles list is still + stored either way — an empty roles list simply means "no role + restriction", i.e. normal permissions apply). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
