bito-code-review[bot] commented on code in PR #44554:
URL: https://github.com/apache/superset/pull/44554#discussion_r4078371189
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -239,6 +249,7 @@ function BigNumberVis({
fontSize,
height: 'auto',
color: numberColor,
+ textAlign: headerAlignment,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Ineffective textAlign on flex</b></div>
<div id="fix">
`.header-line` is `display: flex` (line 247), so `textAlign:
headerAlignment` is a no-op for the text (an anonymous flex item positioned by
`justify-content`). In the overflow path the parent `.text-container` becomes
`display: block` (line 449/492), disabling its `alignItems`, so the big number
stays left-aligned while metric-name/kicker/subheader align. Use
`justifyContent: alignItems` instead.
</div>
</div>
<small><i>Code Review Run #e93aae</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
