rusackas commented on PR #37773: URL: https://github.com/apache/superset/pull/37773#issuecomment-5787544157
@msyavuz to answer your question: yes, with the flag off there's no UI left for an admin to reset someone else's password. The FAB "Reset Password" button is hidden (it was 500ing anyway), the SPA edit-user modal has no password field, and only `PUT /api/v1/security/users/<id>` with a `password` still does it. Self-service resets still work from the SPA profile page, and `ENABLE_LEGACY_FAB_PASSWORD_VIEWS = True` brings the legacy forms back. Whether that's an acceptable default, or whether we want password fields on the SPA edit modal first, is the call I'd like from you, @dpgaspar and @sadpandajoe before this merges. Also rebased on `master` and worked through the open threads: the reset launchers no longer 500, the UPDATING.md paths are fixed, the restart plus `superset init` requirement is documented, and the integration test no longer depends on DB state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
