deepujain commented on PR #44507: URL: https://github.com/apache/superset/pull/44507#issuecomment-5789089876
Regarding the two additional suggestions in [review #07ef0a](https://github.com/apache/superset/pull/44507#issuecomment-5782307749): - Type contract: `NumberFormatFunction` and the callable `NumberFormatter` interface are shared by every number formatter. Widening that shared contract here would promise BigInt support in implementations such as `createThroughputFormatter` and `createSmartNumberFormatter`, which still call `Math.abs(value)`, and `createLengthFormatter`, which divides by Number constants. This change remains a defensive runtime fix for BigInts produced by JSON parsing in the existing numeric-data path. A public BigInt-capable formatter API needs a separate change across those implementations; changing only the shared alias would make that promise inaccurate. - Precision: the PR description explicitly documents Number conversion and approximate human-readable display. Exact integer serialization is not promised; the reported input retains the intended `1.24EiB` display. This was also addressed in the earlier precision disposition. The current head's hosted checks have finished successfully, including frontend validation, all eight Jest shards, Cypress, Playwright, translations, and pre-commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
