codeant-ai-for-open-source[bot] commented on code in PR #44538:
URL: https://github.com/apache/superset/pull/44538#discussion_r4078667612
##########
scripts/change_detector.py:
##########
@@ -151,6 +151,13 @@ def fetch_changed_files_pr(repo: str, pr_number: str) ->
List[str]:
return [file_info["filename"] for file_info in files]
+def fetch_changed_files_compare(repo: str, base_sha: str, head_sha: str) ->
List[str]:
+ """Fetches files changed between two commits using the GitHub compare
API."""
+ compare_url =
f"https://api.github.com/repos/{repo}/compare/{base_sha}...{head_sha}";
+ comparison_data = fetch_files_github_api(compare_url)
+ return [file["filename"] for file in comparison_data["files"]]
Review Comment:
**Suggestion:** The compare API paginates changed files and returns only the
first page by default, so files beyond that page are omitted and affected CI
jobs can be incorrectly skipped.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f2f868ebc8604298a990bf64b4569b17&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f2f868ebc8604298a990bf64b4569b17&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** scripts/change_detector.py
**Line:** 156:158
**Comment:**
*Api Mismatch: The compare API paginates changed files and returns only
the first page by default, so files beyond that page are omitted and affected
CI jobs can be incorrectly skipped.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44538&comment_hash=d06fd5fed0f6cf934e6c04ccdf8de2faa841e3628af1ab6bd360511768500085&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44538&comment_hash=d06fd5fed0f6cf934e6c04ccdf8de2faa841e3628af1ab6bd360511768500085&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
