deepujain commented on PR #44559: URL: https://github.com/apache/superset/pull/44559#issuecomment-5792539366
On the SharedControlAlias widening note (bito review #b039a3): this is pre-existing rather than introduced by this PR. Before the change, sharedControls was annotated Record<string, SharedControlConfig<any>>, whose keyof is already string. The typeof controlConfigs & Record<string, RegisteredControl> intersection is load-bearing: CI lint-frontend proved that dropping it collapses keyof to the literal key union and breaks SharedControlAlias assignments in matrixify.tsx controlSetRows, because a TS object spread does not propagate an index signature. Redesigning SharedControlAlias as a literal union would be a type-contract change beyond this type-preservation fix, so no code change here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
